Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPT-1921] EY claim index data #3366

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[CAPT-1921] EY claim index data #3366

merged 2 commits into from
Nov 7, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Nov 4, 2024 •
edited
Loading

Context

@asmega asmega added the deploy Deploy a review app for this PR label Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3366-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3366-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3366-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3366-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3366-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3366-web.test.teacherservices.cloud/admin

@asmega asmega marked this pull request as ready for review November 4, 2024 12:20
@asmega asmega marked this pull request as draft November 4, 2024 12:26
rjlynch
rjlynch approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - We should consider moving status to a method on the tag, and this helper should just set the colour

@asmega asmega changed the title [LUPEYALPHA-1177] Use incomplete tag if practitioner yet to submit [LUPEYALPHA-1177] EY claim index data Nov 6, 2024
@asmega asmega marked this pull request as ready for review November 6, 2024 13:17
@asmega asmega changed the title [LUPEYALPHA-1177] EY claim index data [CAPT-1921] EY claim index data Nov 6, 2024
rjlynch
rjlynch approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@asmega asmega merged commit 0eff722 into master Nov 7, 2024
14 checks passed
@asmega asmega deleted the ey-claim-states branch November 7, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
business reviewed deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @rjlynch