From c9f17f4f404c467188748bb5f86e360cc71d0259 Mon Sep 17 00:00:00 2001 From: Kenneth Lee Date: Wed, 9 Oct 2024 14:45:27 +0100 Subject: [PATCH] CAPT-1850 show Start button only when the jounrney is open on the landing page --- .../provider/start/landing_page.html.erb | 1 + .../landing_page.html.erb | 3 +++ app/views/student_loans/landing_page.html.erb | 9 ++++++--- config/locales/en.yml | 2 +- spec/features/backlink_spec.rb | 2 +- 5 files changed, 12 insertions(+), 5 deletions(-) diff --git a/app/views/early_years_payment/provider/start/landing_page.html.erb b/app/views/early_years_payment/provider/start/landing_page.html.erb index ab20504ab5..84a7c02dc5 100644 --- a/app/views/early_years_payment/provider/start/landing_page.html.erb +++ b/app/views/early_years_payment/provider/start/landing_page.html.erb @@ -132,6 +132,7 @@ <%= govuk_link_to("early years financial incentive payment", "#") %>.

+ <%# TODO: There isn't any journey closed content, for now hide the button %> <% if @journey_open %> <%= govuk_start_button(text: "Start now", href: claim_path(current_journey_routing_name, "claim")) %> <% end %> diff --git a/app/views/get_a_teacher_relocation_payment/landing_page.html.erb b/app/views/get_a_teacher_relocation_payment/landing_page.html.erb index 382e561692..211f727acd 100644 --- a/app/views/get_a_teacher_relocation_payment/landing_page.html.erb +++ b/app/views/get_a_teacher_relocation_payment/landing_page.html.erb @@ -58,6 +58,8 @@ "contact details for the school where you are employed" ], type: :bullet %> + <%# TODO: There isn't any journey closed content, for now hide the button %> + <% if @journey_open %>

" role="button" draggable="false" class="govuk-button govuk-button--start" data-module="govuk-button"> Start @@ -66,6 +68,7 @@

+ <% end %>

Deadline for applications

diff --git a/app/views/student_loans/landing_page.html.erb b/app/views/student_loans/landing_page.html.erb index b2f99c2a3b..925d60d5a0 100644 --- a/app/views/student_loans/landing_page.html.erb +++ b/app/views/student_loans/landing_page.html.erb @@ -22,13 +22,15 @@

- It takes around 5 minutes to check if you're eligible and another 5 minutes to apply. + It takes around 5 minutes to check if you’re eligible and another 5 minutes to apply.

You must apply before 31 March <%= @academic_year.end_year.to_s %>.

+ <%# TODO: There isn't any journey closed content, for now hide the button %> + <% if @journey_open %>

" role="button" draggable="false" class="govuk-button govuk-button--start" data-module="govuk-button"> Start now @@ -36,12 +38,13 @@ -

+

+ <% end %>

Before you start

- You can use DfE Identity with this service. You'll need to provide your personal details including your National Insurance number and teacher reference number (TRN). + You can use DfE Identity with this service. You’ll need to provide your personal details including your National Insurance number and teacher reference number (TRN).

diff --git a/config/locales/en.yml b/config/locales/en.yml index fbaafa7717..3e8a77055f 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -375,7 +375,7 @@ en: award_description: "claim payment" support_email_address: "studentloanteacherpayment@digital.education.gov.uk" feedback_email: "studentloanteacherpayment@digital.education.gov.uk" - landing_page: "Claim back student loan repayments if you're a teacher" + landing_page: "Claim back student loan repayments if you’re a teacher" questions: academic_year: "Academic year you completed your Initial Teacher Training (ITT)" claim_school_select_error: "Select the school you taught at between %{financial_year}" diff --git a/spec/features/backlink_spec.rb b/spec/features/backlink_spec.rb index ce25372f7c..26ba7e2715 100644 --- a/spec/features/backlink_spec.rb +++ b/spec/features/backlink_spec.rb @@ -79,7 +79,7 @@ expect(page).to have_text("Use DfE Identity to sign in") expect(page).to have_link("Back") click_on "Back" - expect(page).to have_text("Claim back student loan repayments if you're a teacher") + expect(page).to have_text("Claim back student loan repayments if you’re a teacher") end scenario "ECP/LUP journey" do