From d22232c5d3cfd09ae66d63aadc56eae9815b6843 Mon Sep 17 00:00:00 2001
From: Richard Lynch <rjlynchdev@gmail.com>
Date: Fri, 6 Sep 2024 17:07:51 +0100
Subject: [PATCH] Quick copy fix

Need to show the duration of the contract for long term fixed
---
 .../provider/verify_claim_form.rb                           | 6 ++++++
 .../provider/claims/verify_claim.html.erb                   | 3 ++-
 config/locales/en.yml                                       | 2 +-
 .../provider/provider_verifying_claims_spec.rb              | 4 ++--
 4 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/app/forms/journeys/further_education_payments/provider/verify_claim_form.rb b/app/forms/journeys/further_education_payments/provider/verify_claim_form.rb
index 3950386ca3..397e7a60df 100644
--- a/app/forms/journeys/further_education_payments/provider/verify_claim_form.rb
+++ b/app/forms/journeys/further_education_payments/provider/verify_claim_form.rb
@@ -77,6 +77,12 @@ def teaching_hours_per_week
           ).downcase
         end
 
+        def claimant_contract_duration
+          if claim.eligibility.fixed_term_full_year
+            "covering the full academic year "
+          end
+        end
+
         def assertions
           @assertions ||= ASSERTIONS.fetch(contract_type).map do |assertion_name|
             AssertionForm.new(name: assertion_name, parent_form: self)
diff --git a/app/views/further_education_payments/provider/claims/verify_claim.html.erb b/app/views/further_education_payments/provider/claims/verify_claim.html.erb
index 11b816c864..ca2f62c553 100644
--- a/app/views/further_education_payments/provider/claims/verify_claim.html.erb
+++ b/app/views/further_education_payments/provider/claims/verify_claim.html.erb
@@ -64,7 +64,8 @@
               claimant: f.object.claimant_name,
               provider: f.object.claim.school.name,
               hours: f.object.teaching_hours_per_week,
-              type_of_contract: f.object.claimant_contract_of_employment
+              type_of_contract: f.object.claimant_contract_of_employment,
+              duration: f.object.claimant_contract_duration
             ),
           },
           hint: -> do
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 6fd6e7c03a..3e353437b8 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -1174,7 +1174,7 @@ en:
         assertions:
           fixed_contract:
             contract_type:
-              label: "Does %{claimant} have a %{type_of_contract} of employment at %{provider}?"
+              label: "Does %{claimant} have a %{type_of_contract} of employment %{duration}at %{provider}?"
               errors:
                 inclusion: "Select yes if %{claimant} has a fixed term contract of employment at %{provider}"
             teaching_responsibilities:
diff --git a/spec/features/further_education_payments/provider/provider_verifying_claims_spec.rb b/spec/features/further_education_payments/provider/provider_verifying_claims_spec.rb
index 8ceb04f080..49ef570ad4 100644
--- a/spec/features/further_education_payments/provider/provider_verifying_claims_spec.rb
+++ b/spec/features/further_education_payments/provider/provider_verifying_claims_spec.rb
@@ -449,8 +449,8 @@
     expect(page).to have_text "Claim date1 August 2024"
 
     within_fieldset(
-      "Does Edna Krabappel have a fixed-term contract of employment at " \
-      "Springfield A and M?"
+      "Does Edna Krabappel have a fixed-term contract of employment covering " \
+      "the full academic year at Springfield A and M?"
     ) do
       choose "Yes"
     end