From 1cfe1a78effe3242fa899825631c953acca3ac48 Mon Sep 17 00:00:00 2001
From: Stuart Harrison <pezholio@gmail.com>
Date: Wed, 7 Oct 2020 14:11:53 +0100
Subject: [PATCH] Seperate policies in payment with a space

Cantium's CSV parser doesn't like commas in columns, so we're splitting the
policies with a space instead

# Conflicts:
#	CHANGELOG.md
---
 CHANGELOG.md                                 | 1 +
 app/models/payment.rb                        | 2 +-
 spec/models/payment_confirmation_csv_spec.rb | 2 +-
 spec/models/payment_spec.rb                  | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f3df8cda6e..d104c1a0a7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog]
 ## [Unreleased]
 
 - Update payment email copy
+- Seperate policies in payment with a space
 
 ## [Release 084] - 2020-09-30
 
diff --git a/app/models/payment.rb b/app/models/payment.rb
index 705eed17c3..b5f2315394 100644
--- a/app/models/payment.rb
+++ b/app/models/payment.rb
@@ -37,7 +37,7 @@ class Payment < ApplicationRecord
   delegate :scheduled_payment_date, to: :payroll_run
 
   def policies_in_payment
-    claims.map { |claim| claim.policy.to_s }.uniq.sort.join(",")
+    claims.map { |claim| claim.policy.to_s }.uniq.sort.join(" ")
   end
 
   private
diff --git a/spec/models/payment_confirmation_csv_spec.rb b/spec/models/payment_confirmation_csv_spec.rb
index 61e0f513fc..4a695aa8fa 100644
--- a/spec/models/payment_confirmation_csv_spec.rb
+++ b/spec/models/payment_confirmation_csv_spec.rb
@@ -14,7 +14,7 @@
     let(:csv) do
       <<~CSV
         Payroll Reference,Gross Value,Payment ID,NI,Employers NI,Student Loans,Tax,Net Pay,Claim Policies
-        DFE00001,487.48,88b5dba7-ccf1-4ffd-a3ce-20bd3ce1e500,33.9,38.98,0,89.6,325,"MathsAndPhysics,StudentLoans"
+        DFE00001,487.48,88b5dba7-ccf1-4ffd-a3ce-20bd3ce1e500,33.9,38.98,0,89.6,325,"MathsAndPhysics StudentLoans"
       CSV
     end
 
diff --git a/spec/models/payment_spec.rb b/spec/models/payment_spec.rb
index 1fa265361f..bd7d67fc58 100644
--- a/spec/models/payment_spec.rb
+++ b/spec/models/payment_spec.rb
@@ -205,7 +205,7 @@
         create(:claim, :approved, personal_details.merge(policy: MathsAndPhysics))
       ])
 
-      expect(payment.policies_in_payment).to eq("MathsAndPhysics,StudentLoans")
+      expect(payment.policies_in_payment).to eq("MathsAndPhysics StudentLoans")
     end
   end
 end