From 9a6f0e48e22a586ef99441b116cc96ee31f92238 Mon Sep 17 00:00:00 2001
From: Alan Cruikshanks <alan.cruikshanks@gmail.com>
Date: Mon, 14 Oct 2024 17:02:14 +0100
Subject: [PATCH] Clean up return reqs. linked to void return logs

https://eaflood.atlassian.net/browse/WATER-4657

> Part of the work to migrate management of return requirements from NALD to WRLS

Having made return versions and requirements visible to our internal users they have spotted that there are return requirements displayed in WRLS that don't exist.

We know why this is: NALD allows users to delete records. This means a user can create a record in NALD on day 1; we'll see and import the record that night. They can then delete the record (in most cases, it is because a mistake was spotted) on day 2. The import never deletes records, so the errant return requirement remains.

With us taking over management of return requirements, though, it has become important to try to get the 2 systems in sync as much as possible before the import is switched off.

This change builds on the work done in [Add return requirements clean up step to import](https://github.com/DEFRA/water-abstraction-import/pull/1017). It added the job and the script to remove return requirements that no longer exists in NALD and were not linked to any return logs.

Now we're adding a query to delete any return requirements that no longer exist in NALD and are only linked to `void` return logs.