Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong abbreviation for month »February« #362

Open
Edelweiss opened this issue Mar 21, 2018 · 5 comments
Open

wrong abbreviation for month »February« #362

Edelweiss opened this issue Mar 21, 2018 · 5 comments
Assignees

Comments

@Edelweiss
Copy link

HGV abbreviates »February« as »Febr.«

Therefore, on this line of code

https://github.com/DCLP/sosol/blob/master/app/helpers/hgv_meta_identifier_helper.rb#L1904

Feb. should become Febr.

months = ['', 'Jan.', 'Feb.', 'März', 'Apr.', 'Mai', 'Juni', 'Juli', 'Aug.', 'Sept.', 'Okt.', 'Nov.', 'Dez.']
@Edelweiss
Copy link
Author

Edelweiss commented Mar 22, 2018

grep result for »Feb.«

./HGV_meta_EpiDoc//HGV122/121935.xml:33: <origDate when="0485-02-17">17. Feb. 485</origDate>
./HGV_meta_EpiDoc//HGV44/43029.xml:78: <p>Alternativdatierung: 19. Jan. - 5. Feb. 193 v. Chr.</p>
./HGV_meta_EpiDoc//HGV46/45353.xml:34: <origDate notBefore="0710-01-07" notAfter="0710-02-05">7. Jan. - 5. Feb. 710</origDate>

@Edelweiss
Copy link
Author

Edelweiss commented Mar 22, 2018

On papyri/idp.data (cherry-picked from DCLP https://github.com/DCLP/idp.data/tree/issue362)
papyri/idp.data@c9de79c

SoSOL (https://github.com/DCLP/sosol/tree/issue362)
DCLP/sosol@40fdb48
(merged to development and master)

@ryanfb
Copy link
Collaborator

ryanfb commented Apr 3, 2018

The tests in date_test.rb should also be updated to the new abbreviation (currently this causes the tests to fail): https://github.com/DCLP/sosol/blob/master/test/unit/date_test.rb

@Edelweiss
Copy link
Author

Edelweiss commented Apr 4, 2018

Yes, thank you for this report and sorry for the trouble. Updated tests accordingly in the following commit:

DCLP/sosol@f8515f0
(merged to development and master)

@ryanfb
Copy link
Collaborator

ryanfb commented Apr 4, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants