feat(installBundle): add :bundles follower to confirm installation #39
Conversation
0xpatrickdev
commented
Jan 20, 2024
0xpatrickdev
commented
- closes install bundle: check vstorage bundles key #8
✅ Deploy Preview for cosmos-proposal-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| <span | ||
| className="text-sm text-blue-500 hover:text-blue-700 underline cursor-pointer" | ||
| onClick={async () => { | ||
| await window.navigator.clipboard.writeText(endoZipBase64Sha512); |
There was a problem hiding this comment.
what would it cost to avoid ambient access to window?
src/config/agoric/agoric.tsx
Outdated
|
|
||
| const Agoric = () => { | ||
| const { netName } = useNetwork(); | ||
| const { walletAddress, stargateClient } = useWallet(); | ||
| const proposalFormRef = useRef<HTMLFormElement>(null); | ||
| const corEvalFormRef = useRef<HTMLFormElement>(null); | ||
| const bundleFormRef = useRef<HTMLFormElement>(null); | ||
| const watchBundle = useWatchBundle(); |
There was a problem hiding this comment.
watchBundle presumable access the net, yes? but no access to the net is passed around explicitly. What would it cost to remedy that lack of ocap discipline?
I suppose this goes for useWallet too.
There was a problem hiding this comment.
See [c9c1537]. useWallet, agree but deeming out of scope for this pr
src/hooks/useWatchBundle.tsx
Outdated
|
|
||
| export const useWatchBundle = () => { | ||
| const { networkConfig } = useNetwork(); | ||
| const leader = networkConfig ? makeLeader(networkConfig.rpc) : undefined; |
There was a problem hiding this comment.
hm... I think I enhanced casting to accept an RPC client object, i.e. explicit access to the network, and not just a URL that gets turned into network access like casting an int to a pointer.
Or maybe I just figured out how to.
There was a problem hiding this comment.
It seems I need a follower to be able to query :bundles? I'm not sure how this maps wrt things like :1317/agoric/(swingset|vstorage)/* and agd query (vstorage|swingset)... .
makeLeader in u-13 (current version checked in) only take a url or network config object. makeRoundRobinLeader on latest master still seems to only accept strings too
