Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect Wallet > Silent error if network is not selected #43

Open
0xpatrickdev opened this issue Feb 26, 2024 · 2 comments
Open

Connect Wallet > Silent error if network is not selected #43

0xpatrickdev opened this issue Feb 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@0xpatrickdev
Copy link
Collaborator

0xpatrickdev commented Feb 26, 2024 •
edited
Loading

The Connect Wallet button relies on the currently selected network in order to build the payload for suggestChain.

Account for the scenario where a user tries to connect their wallet before a network is selected, either by disabling the button and/or visual feedback like a tooltip or toast.

suggestChain: fetch https://undefined.agoric.net/network-config
index-bc9f6562.js:40 (TypeError#1)
index-bc9f6562.js:40   at suggestChain (https://cosgov.org/assets/index-bc9f6562.js:80:134769)
  at https://cosgov.org/assets/index-bc9f6562.js:98:41386
image
@0xpatrickdev 0xpatrickdev added the bug Something isn't working label Feb 26, 2024
gacogo added a commit to gacogo/cosmos-proposal-builder that referenced this issue May 1, 2024
@gacogo
fix: DCFoundation#43 - asks user to select network when none has been…
2a026d8 
… selected
@gacogo
Copy link
Contributor

gacogo commented May 1, 2024

I think this might suffice?
Screenshot 2024-05-01 at 11 42 56

@0xpatrickdev
Copy link
Collaborator Author

LGTM!

I think this might suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xpatrickdev @gacogo