Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bug Report for CSS margin-inline Validation Issue #45

Open
Alecto opened this issue Oct 11, 2024 · 2 comments
Open

[BUG] Bug Report for CSS margin-inline Validation Issue #45

Alecto opened this issue Oct 11, 2024 · 2 comments
Assignees
Labels
linter issue Issue with html5validator unconfirmed An issue that have no been confirmed

Comments

@Alecto
Copy link

Alecto commented Oct 11, 2024

Describe the bug
The HTML5Validator Action fails when encountering the margin-inline property in CSS. The validator reports that the property "doesn't exist", although it is part of modern CSS specifications.

To Reproduce
Steps to reproduce the behavior:

  1. Set up the Cyb3r-Jak3/html5validator-action in a GitHub Actions workflow.
  2. Use CSS containing the margin-inline property.
  3. Run the workflow.
  4. Observe that the validator reports an error for the margin-inline property.

What is the current bug behavior

The validator does not recognize the margin-inline property and returns an error:

"file:/github/workspace/./assets/css/style.css": error: CSS: "margin-inline": Property "margin-inline" doesn't exist.

Expected behavior
The margin-inline property should be recognized as valid CSS, as it is part of modern CSS specifications, and the validation should pass without errors.

Screenshots
image

Additional context
The GitHub Action YAML configuration used:

name: HTML CSS valid

on:
  pull_request:
  push:
    branches:
      - master

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Tests Integration with Github Actions.
        uses: Cyb3r-Jak3/html5validator-action@master
        with:
          root: ./
          css: true

The W3C Validator supports this property without issue, and margin-inline is part of the modern CSS Logical Properties.

@Alecto Alecto added the unconfirmed An issue that have no been confirmed label Oct 11, 2024
@Cyb3r-Jak3
Copy link
Owner

At first glance, this seems like something related to the upstream library not being up-to-date. Could you try my experimental action using:

name: HTML CSS valid

on:
  pull_request:
  push:
    branches:
      - master

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Tests Integration with Github Actions.
        uses: Cyb3r-Jak3/html5validator-action-experimental@master
        with:
          root: ./
          css: true

This one uses my fork of html5validator which has a more update to jar file

@Cyb3r-Jak3 Cyb3r-Jak3 added the linter issue Issue with html5validator label Oct 11, 2024
@Alecto
Copy link
Author

Alecto commented Oct 12, 2024

Hi there,

I've applied the changes you suggested, and I'm pleased to share that the validation passed successfully! Please find attached the screenshots showing the successful run.

Thank you very much for your help and guidance. If there's anything else you need, feel free to ask.

Best regards,
Andrii

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter issue Issue with html5validator unconfirmed An issue that have no been confirmed
Projects
None yet
Development

No branches or pull requests

2 participants