Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not require : for bracketedSpans attrs #5

Open
mesqueeb opened this issue May 16, 2023 · 0 comments · May be fixed by #10
Open

do not require : for bracketedSpans attrs #5

mesqueeb opened this issue May 16, 2023 · 0 comments · May be fixed by #10
Assignees
@laquasicinque

Comments

@mesqueeb
Copy link
Member

mesqueeb commented May 16, 2023 •
edited
Loading

we should not require a : inside bracketedSpans

work on branch: #10

please note: before working on this issue, there are some unrelated tests failing on production branch. It's best to first fix all failing tests on production, then pull production into branch of #10 again, then start working on these remaining issues.
@mesqueeb mesqueeb changed the title review: {:target="\_blank"} vs {target="\_blank"} and optional {external} shorthand review: {:target="\_blank"} vs {target="_blank"} and optional {external} shorthand May 16, 2023
@mesqueeb mesqueeb changed the title review: {:target="\_blank"} vs {target="_blank"} and optional {external} shorthand review: {:target="_blank"} vs {target="_blank"} May 26, 2023
@mesqueeb mesqueeb changed the title review: {:target="_blank"} vs {target="_blank"} do not require : for bracketedSpans attrs May 26, 2023
@mesqueeb mesqueeb linked a pull request May 26, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laquasicinque laquasicinque

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat/bracketed spans CyCraft/starkdown
2 participants
@mesqueeb @laquasicinque