Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate bracketedSpans plugin from anchor #11

Open
3 tasks
mesqueeb opened this issue May 26, 2023 · 0 comments · May be fixed by #10
Open
3 tasks

separate bracketedSpans plugin from anchor #11

mesqueeb opened this issue May 26, 2023 · 0 comments · May be fixed by #10

Comments

@mesqueeb
Copy link
Member

mesqueeb commented May 26, 2023

bracketedSpans is sort of a new plugin I want to add (see #10 )
but most of the requested features are already available via links with atributes

common markdown should however not include bracketedSpans (nor links with attributes) but should include just converting links.

  • cut out the logic of the attributes of the anchor plugin and save as a new plugin called bracketedSpans this can cover also converting links. When placing the bracketedSpans before the anchor plugin, it will basically convert your links with additional optional bracketedSpans.
  • make sure the anchor plugin still works and leaves the bracketedSpans alone if that plugin is not imported
  • make sure the bracketedSpans plugin covers all tests added in feat/bracketed spans #10

please note: before working on this issue, there are some unrelated tests failing on production branch. It's best to first fix all failing tests on production, then pull production into branch of #10 again, then start working on these remaining issues.

@mesqueeb mesqueeb linked a pull request May 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant