Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #667

Closed
guyluz11 opened this issue Oct 1, 2023 · 7 comments · Fixed by #697
Closed

Fix warnings #667

guyluz11 opened this issue Oct 1, 2023 · 7 comments · Fixed by #697
Assignees
@guyluz11
Labels
good first issue Good for newcomers Improving code organization All the staff that improve code without change to functionality

Comments

@guyluz11
Copy link
Member

guyluz11 commented Oct 1, 2023

Fix warnings

There are currently 44 warnings and 56 hints found by dart analysis.

Please fix as many as you can
@guyluz11 guyluz11 added good first issue Good for newcomers Improving code organization All the staff that improve code without change to functionality labels Oct 1, 2023
@Priyanshu-Maikhuri
Copy link

Hi @guyluz11 I'm interested.

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 3, 2023

Hi @guyluz11 I'm interested.

Great 👍

@Priyanshu-Maikhuri
Copy link

Please assign me this issue

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 4, 2023

No need, create a pr

Please assign me this issue

@Priyanshu-Maikhuri
Copy link

Then how am I supposed to contribute?

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 5, 2023

Then how am I supposed to contribute?

Create a PR and link it to this issue, then I will merge it and will even add hacktoberfest - accepted label on it

This was referenced Oct 21, 2023
Closed
Closed
Merged
Merged
@guyluz11 guyluz11 linked a pull request Dec 1, 2023 that will close this issue
Moving from block to atoms architecture #697
Merged
@guyluz11 guyluz11 self-assigned this Dec 1, 2023
@guyluz11
Copy link
Member Author

guyluz11 commented Dec 1, 2023

Most of the job got done in the mentioned PR, and only 2 warnings are left in this repo.

Closing this issue as complete

Thanks

@guyluz11 guyluz11 closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyluz11 guyluz11

Labels
good first issue Good for newcomers Improving code organization All the staff that improve code without change to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moving from block to atoms architecture guyluz11/cbj_app
2 participants
@guyluz11 @Priyanshu-Maikhuri