Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relax callable typehints to not require pure #563

Closed
wants to merge 1 commit into from
Closed

fix: relax callable typehints to not require pure #563

wants to merge 1 commit into from

Conversation

SamMousa
Copy link

The purity requirement for callbacks is very annoying to deal with, also it is not needed.

  1. PHPStan cannot auto-detect pure functions, so each transformer requires an annotation.
  2. This library should not care wether a transformer is pure; it is not impacted by this.

This solves #550

@romm romm mentioned this pull request Nov 17, 2024
Merged
@romm romm closed this in #578 Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SamMousa