-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phonenumbers should be optional dependecy #42
Comments
What are the advantages of supporting phonenumberslite? phonenumbers is there because we wanted to validate phone_numbers and not to have those validations handled in this library. |
size of phonenumberslite package is 5Mb vs 32.8M of phonenumbers. Also phonenumbers has larger memory footprint. Validation works same in both packages. |
Thanks for this useful package! I agree - dependencies like twilio and nexmo should be optional. This is especially important for docker images, e.g. in my image:
|
Thanks for the input. I agree. There are two things here, The first is making the backend dependencies optional depending on which SMS backend developer opts for. I will cover this in #87 The other one is to replace Thanks again! :D |
It will allow to choose between phonenumbers and phonenumberslite, how it is done in phonenumber_field.
Optional twilio and nexmo dependencies also make sense.
The text was updated successfully, but these errors were encountered: