P2P: Periodically eject unreachable peers from AddressBook + Replace Peer list IndexMap
by BucketMap
#339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes parts of: #178
PeerPinger
incuprate-p2p
. This background task will periodically fetch a random white and gray peers and try to ping them. Replace them in the list if successful, drop it otherwise.AddWhitePeer
request toAddressBookRequest
. Needed for thePeerPinger
to replace white peers.Bucket
asBucketMap
.BucketMap
API for usage withinpeer_list.rs
incuprate-address-book
.Bucketable
trait as a dependency forNetZoneAddress
and implemented discrimination toSocketAddr
.Why
As described in #178, Cuprate will at the moment keep indefinitely any peer contained in its list, even ones that may not be reachable anymore in the long/mid-term.
The use of
BucketMap
instead ofIndexMap
will ensure that we store at mostN
amount of IP addresses from the same subnet. This ensure a form of diversity and could potentially help at mitigating monero-project/research-lab#126