-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reddit killed Search that RedditSharp uses #171
Comments
Hey, I think they reworked their search api and until proper changes are made in reddit sharp, not event he first method will work. The latter two methods will never again work since reddit killed the range search feature. (At least for „common Joe“ devs)
…________________________________
From: Josh Jones <[email protected]>
Sent: Sunday, April 29, 2018 5:10:01 AM
To: CrustyJew/RedditSharp
Cc: Clueless4ever; Author
Subject: Re: [CrustyJew/RedditSharp] Reddit killed Search that RedditSharp uses (#171)
Quick question about this one... are all of the Search() methods broken or just this one with the date ranges in them? I noticed there are three in there:
public Listing<Post> Search(string terms, Sorting sortE = Sorting.Relevance, TimeSorting timeE = TimeSorting.All);
public Listing<Post> Search(DateTime from, DateTime to, Sorting sortE = Sorting.New);
public Listing<Post> Search(DateTimeOffset from, DateTimeOffset to, Sorting sortE = Sorting.New);
I am also not able to get the first one working when trying to get search results from the last week (TimeSorting.Week). Might be user error on my part, but just thought I would check. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#171 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATHdXSmPe777QFmuhnuGR7WxgoPtzzPnks5ttUspgaJpZM4TX7WM>.
|
Hey thanks for the reply! I actually deleted my comment on the thread in
GitHub because the first method is working for me now. My problem was that
I was trying to send it a blank search string.
Rock n roll!
…On Sun, Apr 29, 2018, 5:15 AM Clueless4ever ***@***.***> wrote:
Hey, I think they reworked their search api and until proper changes are
made in reddit sharp, not event he first method will work. The latter two
methods will never again work since reddit killed the range search feature.
(At least for „common Joe“ devs)
________________________________
From: Josh Jones ***@***.***>
Sent: Sunday, April 29, 2018 5:10:01 AM
To: CrustyJew/RedditSharp
Cc: Clueless4ever; Author
Subject: Re: [CrustyJew/RedditSharp] Reddit killed Search that RedditSharp
uses (#171)
Quick question about this one... are all of the Search() methods broken or
just this one with the date ranges in them? I noticed there are three in
there:
public Listing<Post> Search(string terms, Sorting sortE =
Sorting.Relevance, TimeSorting timeE = TimeSorting.All);
public Listing<Post> Search(DateTime from, DateTime to, Sorting sortE =
Sorting.New);
public Listing<Post> Search(DateTimeOffset from, DateTimeOffset to,
Sorting sortE = Sorting.New);
I am also not able to get the first one working when trying to get search
results from the last week (TimeSorting.Week). Might be user error on my
part, but just thought I would check. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<
#171 (comment)>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/ATHdXSmPe777QFmuhnuGR7WxgoPtzzPnks5ttUspgaJpZM4TX7WM
>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ae_KcnyFYWB7c0PpqbhEOl9_1noxWxs-ks5ttaDFgaJpZM4TX7WM>
.
|
is this working for anyone? I cannot get my search to work
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Things/Subreddit.cs:
public Listing Search(DateTime from, DateTime to, Sorting sortE = Sorting.New, int max = -1)
{
}
This function will return Error 503 from now on, because reddit killed the search method.
See annoucement:
https://www.reddit.com/r/changelog/comments/7tus5f/update_to_search_api/
The text was updated successfully, but these errors were encountered: