Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter suggestedAmounts to remove zero amounts or empty objects #1052

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Filter suggestedAmounts to remove zero amounts or empty objects #1052

merged 4 commits into from
Sep 12, 2023

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Sep 8, 2023

Description

Ensuring we do not show zero amounts on giving modal and we show the detail amounts if all suggested amounts are zero.

Changes

  • When saving suggested amounts, filter out zero and empty objects.
  • Removing zero amounts on initial load.
  • Filer out zero amounts when rendering amounts on a gift modal.

@dr-bizz dr-bizz requested a review from wrandall22 September 8, 2023 21:04
@dr-bizz dr-bizz added the On Staging Will be merged to the staging branch by Github Actions label Sep 8, 2023
@wrandall22
Copy link
Contributor

This doesn't appear to have made it to staging.

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Sep 11, 2023

hmmm, It should have: https://github.com/CruGlobal/give-web/actions/runs/6126578705

@wrandall22
Copy link
Contributor

Sorry, I was looking at the wrong file in dev tools. It is there.

@dr-bizz dr-bizz merged commit 9d0b608 into master Sep 12, 2023
5 checks passed
@dr-bizz dr-bizz deleted the fix-0-dollars-giving-options branch September 12, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrandall22 wrandall22 wrandall22 approved these changes

Assignees
No one assigned
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-bizz @wrandall22