Glowstone Error

[kienerxyzzy]

Description

It does not show up in Basins.
Could possibly be a bug with a intended compat mechanic that makes Thermal liquid glowstone fall up

Game Log

no

Debug Information

Client Info

Create:
	Mod Version: 0.5.1j
	Forge Version: 47.3.0
	Minecraft Version: 1.20.1

Graphics:
	Flywheel Version: 0.6.11-13
	Flywheel Backend: INSTANCING
	OpenGL Renderer: NVIDIA GeForce MX330/PCIe/SSE2
	OpenGL Version: 4.6.0 NVIDIA 516.40
	Graphics Mode: options.graphics.fancy

System Information:
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 17.0.8, Microsoft
	JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx3000M -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
	Memory: 757273320 bytes (722 MiB) / 3154116608 bytes (3008 MiB) up to 3154116608 bytes (3008 MiB)
	Total Memory: 7872872448 bytes (7505 MiB) / 8356814848 bytes (7966 MiB)
	CPU: Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz @ 1.19 GHz; 4 cores / 8 threads on 1 socket(s)
	Graphics card #0: Intel(R) UHD Graphics (Intel Corporation (0x8086)); 1024.00 MB of VRAM
	Graphics card #1: NVIDIA GeForce MX330 (NVIDIA (0x10de)); 2048.00 MB of VRAM

Other Mods:
	Thermal Innovation: 11.0.1
	Create Sifter: 1.20.1-1.8.2.j-55
	Create: Ultimate Factory: 1.8.0
	XyCraft: Machines: 0.6.22
	GeckoLib 4: 4.4.9
	Create Deco: 2.0.2-1.20.1-forge
	Create: Copycats+: 2.1.4+mc.1.20.1-forge
	Just Enough Items: 15.20.0.105
	XyCraft: World: 0.6.22
	Create: Netherless: 1.3.0
	Kotlin For Forge: 4.11.0
	Mekanism: 10.4.12
	Create Jetpack: 4.3.2
	Thermal Series: 11.0.6
	CreateArmory: 0.5
	Create Stuff & Additions: 2.0.5
	AlmostUnified: 1.20.1-0.9.4
	Create: Blazing Hot: 0.6.4+forge-mc1.20.1
	Powah: 5.0.7
	Thermal Foundation: 11.0.6
	Thermal Expansion: 11.0.1
	MixinExtras: 0.4.0
	Northstar: 0.1cb-1.20.1
	CoFH Core: 11.0.2
	WorldEdit: 7.2.15+6463-5ca4dff
	Create: Dragon Lib: 1.4.3
	XyCraft: Override: 0.6.22
	Thermal Integration: 11.0.1
	Architectury: 9.2.14
	Create: Vintage Improvements: 1.20.1-0.2.0.3
	Create: Steam 'n' Rails: 1.6.7+forge-mc1.20.1
	Flight Lib: 2.1.0
	Create: Interiors: 0.5.6
	Create: Chromatic Return: 1.0.0
	Cloth Config v10 API: 11.1.136
	XyCraft: Core: 0.6.22
	Create Enchantment Industry: 1.2.9.d
	Create Slice & Dice: 3.3.0
	Create Crafts & Additions: 1.20.1-1.2.4e
	Create: Connected: 0.9.2-mc1.20.1

Server Info

Create:
	Mod Version: 0.5.1j
	Forge Version: 47.3.0
	Minecraft Version: 1.20.1

System Information:
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 17.0.8, Microsoft
	JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx3000M -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
	Memory: 757273320 bytes (722 MiB) / 3154116608 bytes (3008 MiB) up to 3154116608 bytes (3008 MiB)
	Total Memory: 7872872448 bytes (7505 MiB) / 8356814848 bytes (7966 MiB)
	CPU: Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz @ 1.19 GHz; 4 cores / 8 threads on 1 socket(s)
	Graphics card #0: Intel(R) UHD Graphics (Intel Corporation (0x8086)); 1024.00 MB of VRAM
	Graphics card #1: NVIDIA GeForce MX330 (NVIDIA (0x10de)); 2048.00 MB of VRAM

Other Mods:
	Thermal Innovation: 11.0.1
	Create Sifter: 1.20.1-1.8.2.j-55
	Create: Ultimate Factory: 1.8.0
	XyCraft: Machines: 0.6.22
	GeckoLib 4: 4.4.9
	Create Deco: 2.0.2-1.20.1-forge
	Create: Copycats+: 2.1.4+mc.1.20.1-forge
	Just Enough Items: 15.20.0.105
	XyCraft: World: 0.6.22
	Create: Netherless: 1.3.0
	Kotlin For Forge: 4.11.0
	Mekanism: 10.4.12
	Create Jetpack: 4.3.2
	Thermal Series: 11.0.6
	CreateArmory: 0.5
	Create Stuff & Additions: 2.0.5
	AlmostUnified: 1.20.1-0.9.4
	Create: Blazing Hot: 0.6.4+forge-mc1.20.1
	Powah: 5.0.7
	Thermal Foundation: 11.0.6
	Thermal Expansion: 11.0.1
	MixinExtras: 0.4.0
	Northstar: 0.1cb-1.20.1
	CoFH Core: 11.0.2
	WorldEdit: 7.2.15+6463-5ca4dff
	Create: Dragon Lib: 1.4.3
	XyCraft: Override: 0.6.22
	Thermal Integration: 11.0.1
	Architectury: 9.2.14
	Create: Vintage Improvements: 1.20.1-0.2.0.3
	Create: Steam 'n' Rails: 1.6.7+forge-mc1.20.1
	Flight Lib: 2.1.0
	Create: Interiors: 0.5.6
	Create: Chromatic Return: 1.0.0
	Cloth Config v10 API: 11.1.136
	XyCraft: Core: 0.6.22
	Create Enchantment Industry: 1.2.9.d
	Create Slice & Dice: 3.3.0
	Create Crafts & Additions: 1.20.1-1.2.4e
	Create: Connected: 0.9.2-mc1.20.1

[VoidLeech]

Create/src/main/java/com/simibubi/create/foundation/fluid/FluidRenderer.java

Lines 112 to 116 in d48a504

	if (fluidAttributes.isLighterThanAir())
	TransformStack.of(ms)
	.translate(center)
	.rotateXDegrees(180)
	.translateBack(center);

Fluids lighter than air are rotated 180 degrees (as can be seen in the fluid tank)

Such fluids are actually visible in spectator if you maneuver underneath the basin.

Dev branch has slightly different visual behaviour and z-fighting on the item drain:

Just very quickly I tried comparing with Direction.UP if the fluid is lighter than air here:

Create/src/main/java/com/simibubi/create/foundation/fluid/FluidRenderer.java

Line 119 in d48a504

if (side == Direction.DOWN && !renderBottom)

Which works to fix this for the basin and drain, but then breaks the fluid tank/spout. No time atm to look at it further.