Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PonderWorld does not implement all overloads of Level#addParticle and Level#addAlwaysVisibleParticle #7232

Open
rbasamoyai opened this issue Dec 21, 2024 · 0 comments
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working

Comments

@rbasamoyai
Copy link
Contributor

Description

While editing ponder scenes for Create Big Cannons, I noticed that some scenes using certain particles did not spawn them correctly. These particles are cannon plumes that spawns children cannon smoke particles that are always visible in the world. The method used is Level#addParticle(ParticleOptions, boolean, double, double, double, double, double, double). One such use case can be seen here: https://github.com/Cannoneers-of-Create/CreateBigCannons/blob/multiversion/src/main/java/rbasamoyai/createbigcannons/effects/particles/plumes/BigCannonPlumeParticle.java#L58-L59.

Upon debugging, it seems that this method, while called through WrappedClientWorld, is not implemented in PonderWorld. Further inspection appears to show that Level#addAlwaysVisibleParticle(ParticleOptions, boolean, double, double, double, double, double, double) is also not implemented.

Game Log

N/A

Debug Information

N/A

@rbasamoyai rbasamoyai added the type: bug Issue where something isn't working label Dec 21, 2024
@IThundxr IThundxr added the status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants