Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Extra validation required when extenstion set to NULL #28

Open
lenamtl opened this issue Aug 22, 2022 · 0 comments
Open

[Question] Extra validation required when extenstion set to NULL #28

lenamtl opened this issue Aug 22, 2022 · 0 comments

Comments

@lenamtl
Copy link

lenamtl commented Aug 22, 2022

Hi,

I found a couple issues with file name, also when extension is set to NULL

'extensions' => null, // null allow any type of file

The code allow file name like this

Case 1: myfilehasnoextension
***Not so sure how to handle this case has when downloading browser add xml extension if any...

Case 2: myfile.txt space and / characters after the dot
I remove space and replacing special characters during the validation

Case 3: myfile'have_apostrophe.txt
I'm replacing apostrophe during the validation

I think even if the extension is set to NULL, it should maybe check if there is a dot and some letter after the dot...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant