Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Phase Retrieval code in old WaveDiff with Random Seed setting #91

Open
jeipollack opened this issue Dec 8, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@jeipollack
Copy link
Contributor

jeipollack commented Dec 8, 2023

Validation of WaveDiff 2.0.0 has been done using the older version of the code in the branch main_random_seed that was upgraded to include the user setting of a fixed random seed.

Tobias' Phase Retrieval implementation in the old code should be upgraded with the fixed random seed in two commit states It's possible to cherry-pick one of the commit states in tf_psf_field , but not the other in long-runs/train_eval_plot_script_click_multi_cycle.py as they include some other unnecessary changes (bad practice on my part). But since they're really simple, so these changes could be added by hand.

Once Tobias updates his Phase Retrieval code (in the old version) it should be used to produce new baseline results to be used for validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants