Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PSF model with a physical layer #123

Open
jeipollack opened this issue Feb 28, 2024 · 2 comments
Open

Implement PSF model with a physical layer #123

jeipollack opened this issue Feb 28, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jeipollack
Copy link
Contributor

To address various issues in the modelling like centroid problem, chip misalignments, and including a prior a new PSF model class needs to be added to WaveDiff >v2.0.x.

It's implementation is illustrated in the far left in this image:
IMG_20240213_181157

The PSF model class is in version 1.0 but requires refactoring to be included in v2.0.x

@jeipollack jeipollack added the enhancement New feature or request label Feb 28, 2024
@jeipollack jeipollack self-assigned this Feb 28, 2024
@jeipollack
Copy link
Contributor Author

jeipollack commented Mar 20, 2024

Hi @tobias-liaudat, I need a reminder about the implementation on padding the Zernikes. I see there is already a method for padding L321, which is implemented in the method compute_zernikes at L484 and executed in the call class method.

@jeipollack
Copy link
Contributor Author

Note, I am still making changes to psf_model_physical_polychromatic.py module as I begin to write unit tests and think about interfaces with the other parts of the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant