Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure error.log exists and is writable on installation #23

Open
starstryder opened this issue Feb 17, 2020 · 2 comments
Open

make sure error.log exists and is writable on installation #23

starstryder opened this issue Feb 17, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@starstryder
Copy link
Contributor

check that whatever log file is given in the settings file can actually be written too and don't proceed if it's not.

@starstryder starstryder added the bug Something isn't working label Feb 17, 2020
@dpi209
Copy link
Collaborator

dpi209 commented Feb 17, 2020

PHP is actually quite good at making this non-fatal - if you ini_set a log file that isn't writeable or doesn't exist, it falls back to the default SAPI log location (for Apache: the server-wide error_log). Since we aready checked that $BASE_DIR exists, we have following options:

a) Create the folder "logs" after we write the config file and be done with it or
b) Add a tab to the installer, where the user can check (checkbox) whether to log or not and check (radio) either logfile and add a location for said file, use the default SAPI log file or use syslog/eventlog
c) implement a and track b as an improvement.

I'm okay with either.

@starstryder
Copy link
Contributor Author

This is a double sided issue: Want people to know where they are writing errors. Let's leave this open with the discussion until the code can shout at people accordingly. Admin panel or somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants