Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the actual ICS20 protocol #195

Open
DariuszDepta opened this issue Jul 2, 2024 · 0 comments
Open

Implement the actual ICS20 protocol #195

DariuszDepta opened this issue Jul 2, 2024 · 0 comments
Labels
IBC IBC support
Milestone

Comments

@DariuszDepta
Copy link
Member

I guess, you are using a simplified version of the actual ICS-20 protocol here, but I do want to note that this is not how the denom works in the actual protocol. We will have to make changes to this if we want to implement IBC Callbacks later down the road.
Here's a quick example of how it looks on chain:
If I send ujuno from Juno to Osmosis, the denom is ujuno. If I send it back from Osmosis to Juno, it is transfer/channel-42/ujuno.
According to the spec, it's formatted as {ics20Port}/{ics20Channel}/{denom} using the source port and channel (so the ones on Osmosis in my example). To detect that, we would need to check for that prefix and remove it to get the denom on the receiving chain.
Side note: On most chains this denom is also different than what is shown to the bank module because it gets hashed with Sha256 and prefixed with ibc/

Originally posted by @chipshort in #184 (comment)

@DariuszDepta DariuszDepta added the IBC IBC support label Jul 2, 2024
@DariuszDepta DariuszDepta added this to the 3.0.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IBC IBC support
Projects
None yet
Development

No branches or pull requests

1 participant