Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor inconsistencies between multi 'windows' associated with the same peer #509

Open
ash-mcc opened this issue May 9, 2024 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@ash-mcc
Copy link
Contributor

ash-mcc commented May 9, 2024

Minor GUI inconsistencies...
When I open open two REPL windows against the same peer.
Then change the Account dropdown in REPL #a and execute say a transaction.
The Account dropdown in REPL #b doesn't auto change, even though its Balance value does.
Also, if I open a Wallet window.
And similarly switch between Accounts.
The Convex Coins value does change appropriately but the Address value doesn't change appropriately.

@mikera
Copy link
Member

mikera commented May 31, 2024

Thanks for the report will check it out!

@mikera mikera self-assigned this May 31, 2024
@mikera mikera added the bug Something isn't working label May 31, 2024
@mikera
Copy link
Member

mikera commented Oct 3, 2024

OK I think I found a couple of issues to fix:

  • Opening a wallet window should really create a new independent connection
  • REPL windows should also have fully independent connections

Auto-refresh, will think about a bit more. Querying balances is pretty cheap but I still don't think we want clients spamming with constant balance requests every 0.5s or so. Probably refresh needs to be on actions only.

@mikera mikera added the enhancement New feature or request label Oct 3, 2024
@ash-mcc
Copy link
Contributor Author

ash-mcc commented Oct 3, 2024

Thanks for looking into this Mike.
I understand that auto-refresh probably isn't desirable because of its cost.
I also noticed that the manual Refresh button on a Wallet window doesn't seem to update the CVM value. But maybe that part'n'parcel of the same thing that you're going to fix with independent connections. Anyway, I'll give it a re-try once I see that you've completed this Enhancement. Ta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants