BuddyBoss Email notification formatting and content errors.

[SteveMccollough]

1. The BuddyBoss default email notification for messages creates a formatting error.
   
   Possibly related:
   I expected a Subject area to be available in the compose new email window. I expected tab to advance from one area to another. It looks like the error involves the content quoted as subject or subject quoted as content. The user may be confused by a TO: field much larger than the content area.

2. Change Border radius to 20% for the avatar.

[rgilman]

The formatting error looks like a real bug. Somehow their code is converting all < and > to < and >. This is what sanitize_text_field does but it shouldn't be applied to the message text. I've searched but have yet to find where exactly in the code the problem lies. It took me a while but I've found a simple workaround that involves changing them back. I'm able to do this via a hook.

The BuddyBoss handling of Subject is weird. As you say, they don't provide a field for it but they do store an excerpt from the first message in the DB and use that as the subject, so it is "content quoted as subject." At some point, it would be nice to add a subject field but I don't yet see an easy way to do that via hooks or actions.

I agree it would be nice to advance by tab. I'm not sure how we would add that.

I've adjusted the relative sizes of the TO: field and the compose area. The larger upper area can be useful when replying to a long thread but it doesn't make sense for new threads.

I'm still working on the layout and will adjust the border radius for any avatars that get included.

[SteveMccollough]

From what little I remember rummaging around, some were suggesting the problems with email had to do with how BuddyBoss used emails in a strange way. The difficulty may be in the split of emails between "plain text" and "html" along with a legacy path of a previous fork. I thought I understood the path of email construction, but when I recreated the path with a copy php file in the child theme, I was unable to modify the template outputs in any way.

[rgilman]

The email-related issues here are now all fixed. See #25. The subject-line issue gets carried forward in #73.