Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create standards cheatsheet #35

Open
rgilman opened this issue Sep 26, 2018 · 4 comments
Open

Create standards cheatsheet #35

rgilman opened this issue Sep 26, 2018 · 4 comments
Assignees

Comments

@rgilman
Copy link
Member

rgilman commented Sep 26, 2018

We need to gather up all of the standards we've discussed in Game Plan for CI Web Dev/Ops and BFCom style guide (and anywhere else).

It would be great to have a summary cheatsheet at least of the main points.

Here's a start on gathering the standard but not really a cheatsheet yet (which will need more specifics):

I'll start by creating a google doc that we can all contribute to and comment on.

@rgilman rgilman self-assigned this Sep 27, 2018
@iangilman
Copy link
Member

iangilman commented Sep 27, 2018

Sounds good.

BTW, your markup links are broken... you don't need the url part.

@rgilman
Copy link
Member Author

rgilman commented Sep 28, 2018

I've started this at CI Web DevOps Standards Cheatsheet. Please take a look. In the text I ask for comments but you here should also feel free to just add things.

@iangilman, thanks – fixed.

@rgilman
Copy link
Member Author

rgilman commented Sep 28, 2018

One of the standards for PHP that's news to me is to end each file with a blank new line. It's just a warning but recommended. My git client Tower is flagging this.

@iangilman
Copy link
Member

The cheat sheet looks good; I've added some comments.

The newline at the end of each file is a UNIX thing, and its part of Git in general; nothing to do with PHP specifically. We'll set our editors up to take care of this automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants