From 7b6966e6e285f08b82d6ce6427c1554a5359c3c1 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Tue, 24 Sep 2024 22:30:00 +0300 Subject: [PATCH 1/3] Update COMMUNITY_MEMBERSHIP.md --- COMMUNITY_MEMBERSHIP.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/COMMUNITY_MEMBERSHIP.md b/COMMUNITY_MEMBERSHIP.md index 79e830c32..551ff9229 100644 --- a/COMMUNITY_MEMBERSHIP.md +++ b/COMMUNITY_MEMBERSHIP.md @@ -66,7 +66,7 @@ issues and PRs assigned to them. ## Approver -Code approvers are members that have signed an ICLA and have been granted +Code approvers are members who have signed an ICLA and have been granted additional commit privileges. While members are expected to provided code reviews that focus on code quality and correctness, approval is focused on holistic acceptance of a contribution including: backwards / forwards From f72c37682742d194851726048ccef2c285326718 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Tue, 24 Sep 2024 22:33:26 +0300 Subject: [PATCH 2/3] Update CODING-CONVENTIONS.md --- CODING-CONVENTIONS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODING-CONVENTIONS.md b/CODING-CONVENTIONS.md index 157559f45..9b1f07340 100644 --- a/CODING-CONVENTIONS.md +++ b/CODING-CONVENTIONS.md @@ -11,7 +11,7 @@ This document contains guidelines (some stricter than others) so we can be consi The guidelines are intended to facilitate working together not to facilitate reviews that criticize without adding value. -Some guidelines are personal opinion. The idea being we make a decision once, document it, and apply it for consistency. Again, we can then spend more time on the interesting issues and less time discussing coding conventions :-) +Some guidelines are personal opinion. The idea is that we make a decision once, document it, and apply it for consistency. Again, we can then spend more time on the interesting issues and less time discussing coding conventions :-) # 2 General Design Philosophy From fadd093564098c7ebb1a0f11b72ebf09a87cee53 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Tue, 24 Sep 2024 22:38:23 +0300 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bce549d01..f96b0c08c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -167,7 +167,7 @@ experimental flag to disable parallel processing `--Xmetadata-files-parallel-pro ### Bugs Fixed - Update of Azure libraries (transitive via signers library) and manual override to fix CVE-2023-1370 -- Fix issue with some third party libraries not including logs in the web3signer logs due missing slf4j2 library +- Fix issue with some third party libraries not including logs in the web3signer logs due to missing slf4j2 library --- ## 23.3.0