Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements SingleAttestation handling #8884

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Implements SingleAttestation handling #8884

merged 12 commits into from
Dec 5, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Dec 4, 2024 •
edited
Loading

Changes related to API are are not part of this PR.
I added non-related debug logs in ThrottlingSyncSource (I think we need them)

  • implements VC side, where we dynamically select which attestation type to produce
  • implements BN side, where we validate it and convert it to aggregated attestation during processing
  • ValidatableAttestation::getAttestation will return the converted attestation
  • ValidatableAttestation::getUnconvertedAttestation will return the original single attestation, mainly used for EventSubscription

related to #8804

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr mentioned this pull request Dec 4, 2024
Closed
2 tasks
mehdi-aouadi
mehdi-aouadi reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the logic and flow LGTM, just some nits and possible refactoring

@tbenr
Copy link
Contributor Author

tbenr commented Dec 5, 2024

Overall the logic and flow LGTM, just some nits and possible refactoring

Thanks for the good feedback! I should have addressed all of them

mehdi-aouadi
mehdi-aouadi approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice clean up and refactoring!

rolfyone
rolfyone approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found it super interesting that we clearly see aggregations vs. attestations now on the event stream, that could be fun... looks good.

@rolfyone rolfyone merged commit fbf7359 into Consensys:master Dec 5, 2024
17 checks passed
@tbenr tbenr deleted the singleAttestation-logic branch December 6, 2024 04:33
@tbenr tbenr mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

@mehdi-aouadi mehdi-aouadi mehdi-aouadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbenr @mehdi-aouadi @rolfyone