feat: replace RPC provider from Alchemy to Infura DIN #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanti42
requested review from
Akaryatrh and
stanleyyconsensys
and removed request for
a team
khanti42
force-pushed
the
feat/sf-703
branch
from
8a4a672 to
a94bb1d
Compare
|
|
| import { getRPCUrl } from './rpc-provider'; | ||
|
|
||
| describe('getRPCUrl', () => { | ||
| Config.rpcApiKey = 'test'; |
There was a problem hiding this comment.
Suggested change
| Config.rpcApiKey = 'test'; | |
| beforeEach(function () { | |
| Config.rpcApiKey = 'API_KEY'; | |
| }); | |
| afterEach(function () { | |
| Config.rpcApiKey = undefined | |
| }); |
reset it, in case you have some unexpected behaviour (the way using before and after is not suggest by MM, but i think it is okay for that case)
stanleyyconsensys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to replace the Alchemy RPC provider by Infura DIN one.
The required changes in the CI/CD workflow will happen elsewhere.