Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArtifactManager should not carsh entirely if some contracts don't have MD hash #12

Open
cd1m0 opened this issue Apr 17, 2023 · 0 comments
Open

ArtifactManager should not carsh entirely if some contracts don't have MD hash #12

cd1m0 opened this issue Apr 17, 2023 · 0 comments
Assignees
@cd1m0

Comments

@cd1m0
Copy link
Collaborator

cd1m0 commented Apr 17, 2023

Currently we rely on the contract metadata hash embedded in the bytecode to map contract code back to compiler artifacts.
However in certain cases the metadata may be missing. Currently if one artifact doesn't have MD, then the ArtifactManager crashes here:

https://github.com/ConsenSys/sol-dbg/blob/main/src/debug/artifact_manager.ts#L157

It would be nice for the ArtifactManager to not crash there, as the debugger can work with some artifacts missing.
@cd1m0 cd1m0 self-assigned this Apr 17, 2023
@cd1m0 cd1m0 changed the title ArtifactManager should not carsh entirely if some contracts don't have MD ArtifactManager should not carsh entirely if some contracts don't have MD hash Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cd1m0 cd1m0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cd1m0