From 09126261bf725f630e79af84d128504dd654fff4 Mon Sep 17 00:00:00 2001 From: antews Date: Sat, 7 Dec 2024 11:11:25 +0300 Subject: [PATCH 1/9] gas-price-cap-time-of-day-multipliers.toml --- config/common/gas-price-cap-time-of-day-multipliers.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common/gas-price-cap-time-of-day-multipliers.toml b/config/common/gas-price-cap-time-of-day-multipliers.toml index 36155bd6b..8492d6d65 100644 --- a/config/common/gas-price-cap-time-of-day-multipliers.toml +++ b/config/common/gas-price-cap-time-of-day-multipliers.toml @@ -1,7 +1,7 @@ ## # Time of day multipliers for dynamic gas price cap calculation: # -# TDM stands for "Time of Day Mutliplier" and has a range of values between 0.25 - 1.75. +# TDM stands for "Time of Day Multiplier" and has a range of values between 0.25 - 1.75. # # When we expect the L1 gas price to be low, for example on a Saturday night, the TDM will be at it's highest because # we want to increase the rate at which we increase the threshold to try and settle within this time window. From 68eca05e8adb8076f3ce801b91d88e6120592166 Mon Sep 17 00:00:00 2001 From: antews Date: Sat, 7 Dec 2024 11:18:23 +0300 Subject: [PATCH 2/9] Subtract --- prover/symbolic/constructors.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prover/symbolic/constructors.go b/prover/symbolic/constructors.go index 9f442148a..45d90128f 100644 --- a/prover/symbolic/constructors.go +++ b/prover/symbolic/constructors.go @@ -60,7 +60,7 @@ func (expr *Expression) Neg() *Expression { } /* -Substract two expressions +Subtract two expressions Deprecated: Use [Sub] instead of this function as it will be made private. */ From e593a8054688948934a5a651a30ed17145a6ab76 Mon Sep 17 00:00:00 2001 From: antews Date: Sat, 7 Dec 2024 11:20:47 +0300 Subject: [PATCH 3/9] Subtract --- prover/protocol/compiler/univariates/multi_to_single_point.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prover/protocol/compiler/univariates/multi_to_single_point.go b/prover/protocol/compiler/univariates/multi_to_single_point.go index 27020fbe8..ee96c018f 100644 --- a/prover/protocol/compiler/univariates/multi_to_single_point.go +++ b/prover/protocol/compiler/univariates/multi_to_single_point.go @@ -281,7 +281,7 @@ func (ctx mptsCtx) accumulateQuotients(run *wizard.ProverRuntime) { } /* - Substract by the lagrange interpolator and get the quotient + Subtract by the lagrange interpolator and get the quotient */ for j, hpos := range ctx.xPoly[polHandle.GetColID()] { var lagrange sv.SmartVector = sv.NewRegular(lagranges[hpos]) From fb03436bb8f5c5c9faf620d505c7194655519cb5 Mon Sep 17 00:00:00 2001 From: antews Date: Sat, 7 Dec 2024 11:24:13 +0300 Subject: [PATCH 4/9] Subtraction --- prover/symbolic/simplify/cost_stat.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prover/symbolic/simplify/cost_stat.go b/prover/symbolic/simplify/cost_stat.go index f33ecc8db..217f875cf 100644 --- a/prover/symbolic/simplify/cost_stat.go +++ b/prover/symbolic/simplify/cost_stat.go @@ -62,7 +62,7 @@ func evaluateNodeCosts(nodes ...sym.Node) (s costStats) { // The technique here is to to use addition for small // coefficients because this is a faster than multiplying // in a field element. We do that up to 2 and -2. The - // second assumption is that addition and substraction + // second assumption is that addition and subtraction // are equivalent in term of runtime. Otherwise, this is // done with a multiplication and an addition. From b9653fdf69f7af0ca319e8b52d27d6fbdcca17a5 Mon Sep 17 00:00:00 2001 From: antews Date: Sat, 7 Dec 2024 11:27:48 +0300 Subject: [PATCH 5/9] Subtract --- prover/maths/common/vector/vector.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prover/maths/common/vector/vector.go b/prover/maths/common/vector/vector.go index 3bee37017..c05cdb989 100644 --- a/prover/maths/common/vector/vector.go +++ b/prover/maths/common/vector/vector.go @@ -122,7 +122,7 @@ func Add(res, a, b []field.Element, extras ...[]field.Element) { } } -// Sub substracts two vectors `a` and `b` and put the result in `res` +// Sub subtracts two vectors `a` and `b` and put the result in `res` // `res` must be pre-allocated by the caller and res, a and b must all have // the same size. // res == a or res == b or both is valid assignment. From d622f92960b8a24656254d86e3d35f2d36da148c Mon Sep 17 00:00:00 2001 From: antews Date: Sat, 7 Dec 2024 11:29:56 +0300 Subject: [PATCH 6/9] Subtract --- sdk/src/core/utils/__tests__/shared.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/src/core/utils/__tests__/shared.test.ts b/sdk/src/core/utils/__tests__/shared.test.ts index 01e4e9cb4..dd0f61ad4 100644 --- a/sdk/src/core/utils/__tests__/shared.test.ts +++ b/sdk/src/core/utils/__tests__/shared.test.ts @@ -3,7 +3,7 @@ import { isEmptyBytes, isNull, isString, isUndefined, subtractSeconds } from ".. describe("Shared utils", () => { describe("subtractSeconds", () => { - it("should substract X seconds to the current date", () => { + it("should subtract X seconds to the current date", () => { const currentDate = new Date("2024-04-08T00:12:10.000Z"); expect(subtractSeconds(currentDate, 10)).toStrictEqual(new Date("2024-04-08T00:12:00.000Z")); }); From 8bc4da6ea5befdffee06aad603a8c07ff596c40f Mon Sep 17 00:00:00 2001 From: antews Date: Sat, 7 Dec 2024 11:34:55 +0300 Subject: [PATCH 7/9] Subtract --- prover/symbolic/constructor_test.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/prover/symbolic/constructor_test.go b/prover/symbolic/constructor_test.go index 5613d3ac9..1df464939 100644 --- a/prover/symbolic/constructor_test.go +++ b/prover/symbolic/constructor_test.go @@ -56,31 +56,31 @@ func TestConstructor(t *testing.T) { Actual: a.Sub(b), ExpectedOperator: LinComb{Coeffs: []int{1, -1}}, ExpectedParent: []*Expression{b, a}, - Explainer: "Normally substracting two variables should create a LinComb object", + Explainer: "Normally subtracting two variables should create a LinComb object", }, { Actual: a.Sub(zero), ExpectedOperator: a.Operator, ExpectedParent: []*Expression{}, - Explainer: "When substracting zero, this should be simplified into a no-op", + Explainer: "When subtracting zero, this should be simplified into a no-op", }, { Actual: a.Sub(a), ExpectedOperator: zero.Operator, ExpectedParent: []*Expression{}, - Explainer: "When substracting a with itself, this should be simplified into zero", + Explainer: "When subtracting a with itself, this should be simplified into zero", }, { Actual: a.Sub(one).Sub(one), ExpectedOperator: LinComb{Coeffs: []int{1, 1}}, ExpectedParent: []*Expression{a, NewConstant(-2)}, - Explainer: "When substracting twice by a constant, this should be simplified into LinComb with only `1` as coeffs", + Explainer: "When subtracting twice by a constant, this should be simplified into LinComb with only `1` as coeffs", }, { Actual: a.Sub(b).Sub(c), ExpectedOperator: LinComb{Coeffs: []int{1, -1, -1}}, ExpectedParent: []*Expression{a, b, c}, - Explainer: "When substracting a with b then c, this should be regrouped into a single linear combination", + Explainer: "When subtracting a with b then c, this should be regrouped into a single linear combination", }, { Actual: a.Mul(b), @@ -153,12 +153,12 @@ func TestImmutableConstructors(t *testing.T) { { Actual: Sub(a, b, 1), Expected: aVar.Sub(bVar).Sub(one), - Explainer: "Substracting two metadata and a constant", + Explainer: "Subtracting two metadata and a constant", }, { Actual: Sub(aVar, bVar, c), Expected: aVar.Sub(bVar).Sub(cVar), - Explainer: "Substracting two expressions and a metadata", + Explainer: "Subtracting two expressions and a metadata", }, { Actual: Mul(a, b, 1), From 428a8e0387b42bdf7d81a54c26f1bfea87ba6ee6 Mon Sep 17 00:00:00 2001 From: antews Date: Sat, 7 Dec 2024 11:36:30 +0300 Subject: [PATCH 8/9] Subtract --- prover/symbolic/expression_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/prover/symbolic/expression_test.go b/prover/symbolic/expression_test.go index 0f833f4d5..d986b82de 100644 --- a/prover/symbolic/expression_test.go +++ b/prover/symbolic/expression_test.go @@ -112,7 +112,7 @@ func TestLCConstruction(t *testing.T) { { /* - Adding y then substracting x should give back (y) + Adding y then subtracting x should give back (y) */ expr1 := x.Add(y).Sub(x) require.Equal(t, expr1, y) @@ -149,7 +149,7 @@ func TestProductConstruction(t *testing.T) { { /* - Adding y then substracting x should give back (y) + Adding y then subtracting x should give back (y) */ expr1 := x.Mul(y).Mul(x) require.Equal(t, 2, len(expr1.Children)) From 4e76c26b8f4a47f3b397d514ec7152649e3e15b7 Mon Sep 17 00:00:00 2001 From: antews Date: Sat, 7 Dec 2024 11:38:54 +0300 Subject: [PATCH 9/9] Subtraction --- prover/symbolic/evaluation_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prover/symbolic/evaluation_test.go b/prover/symbolic/evaluation_test.go index e86d2cc5f..446f58f99 100644 --- a/prover/symbolic/evaluation_test.go +++ b/prover/symbolic/evaluation_test.go @@ -259,7 +259,7 @@ func ExpressionContainingAllCases() *Expression { expr = expr.Add(c.Add(b)) expr = expr.Add(c.Add(c)) - // Substraction + // Subtraction expr = expr.Add(a.Sub(a)) expr = expr.Add(a.Sub(b)) expr = expr.Add(a.Sub(c))