Prover: fix empty to address decoding #403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreBelling
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=========================================
Coverage 70.17% 70.17%
Complexity 1070 1070
=========================================
Files 306 306
Lines 12337 12337
Branches 1179 1179
=========================================
Hits 8658 8658
Misses 3200 3200
Partials 479 479
*This pull request uses carry forward flags. Click here to find out more. |
jpnovais
previously approved these changes
Dec 6, 2024
Tabaie
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Tabaie
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Signed-off-by: AlexandreBelling <[email protected]>
jpnovais
previously approved these changes
Dec 10, 2024
AlexandreBelling
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
AlexandreBelling
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
AlexandreBelling
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
jpnovais
approved these changes
Dec 11, 2024
|
@AlexandreBelling will this require an upgrade of the compressor as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a decoding error in the decompression logic. The error is without any effect on the production as decoding does not happen on the prover front but it shows up when testing.
The prover would decode "0x0" when given "null" as an address.
Checklist