Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

err(modexp): returns a 77 error when modexp overflows #388

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlexandreBelling
Copy link
Contributor

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@AlexandreBelling AlexandreBelling marked this pull request as ready for review December 3, 2024 21:35
@AlexandreBelling AlexandreBelling force-pushed the prover/exit-77-when-overflowing-modexp branch from 7aa7047 to 1820a60 Compare December 3, 2024 21:38
@AlexandreBelling AlexandreBelling added the Prover Tag to use for all work impacting the prover label Dec 3, 2024
@AlexandreBelling AlexandreBelling self-assigned this Dec 3, 2024
gusiri
gusiri previously approved these changes Dec 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (5fa9eb9) to head (1e37330).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #388   +/-   ##
=========================================
  Coverage     70.17%   70.17%           
  Complexity     1070     1070           
=========================================
  Files           306      306           
  Lines         12337    12337           
  Branches       1179     1179           
=========================================
  Hits           8658     8658           
  Misses         3200     3200           
  Partials        479      479           
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 67.86% <ø> (ø) Carriedforward from 1820a60

*This pull request uses carry forward flags. Click here to find out more.

@gusiri gusiri self-requested a review December 11, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants