Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add more checks to TokenBridge.initialize() #380

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

kyzooghost
Copy link
Contributor

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.22%. Comparing base (8cf2866) to head (69856ab).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #380      +/-   ##
============================================
+ Coverage     70.17%   70.22%   +0.04%     
- Complexity     1070     1072       +2     
============================================
  Files           306      306              
  Lines         12337    12328       -9     
  Branches       1179     1182       +3     
============================================
- Hits           8658     8657       -1     
+ Misses         3200     3179      -21     
- Partials        479      492      +13     
Flag Coverage Δ *Carryforward flag
hardhat 98.71% <100.00%> (+<0.01%) ⬆️
kotlin 67.89% <ø> (+0.02%) ⬆️ Carriedforward from b46c493

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
contracts/contracts/tokenBridge/TokenBridge.sol 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

@kyzooghost kyzooghost marked this pull request as ready for review December 10, 2024 12:32
@kyzooghost kyzooghost requested a review from a team as a code owner December 10, 2024 12:32
alainncls
alainncls previously approved these changes Dec 10, 2024
@kyzooghost kyzooghost requested a deployment to docker-build-and-e2e December 11, 2024 02:51 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants