Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Coordinator config tests for Local Stack config #402

Open
3 tasks
jpnovais opened this issue Dec 5, 2024 · 2 comments
Open
3 tasks

Decouple Coordinator config tests for Local Stack config #402

jpnovais opened this issue Dec 5, 2024 · 2 comments
Labels

Comments

@jpnovais
Copy link
Collaborator

jpnovais commented Dec 5, 2024

Description

Coordinator configuration files inside /config/coordinator/*.toml are used in the Unit tests and in to configure the localstack. This coupling causes error when we update the configurations for the local stack even though the functionality was not broken. As configs got bigger and bigger this gets more and more complex when it fails.

We should have 2 separate set of configuration files:

  • coordinator/app/src/test/resources/**.toml for the unit tests
  • config/coordoniator/**.toml to configure the local stack (has we have)

To ensure that files inside config/coordoniator/**.toml are still valid, we shall have Unit test that loads those files, but does not make assertions on specific values. This will ensure the example we be compatible with the code.

Motivation

Improve developer experience and stop waiting time fixing tests

Tasks

  • Adap the Unit test to read the files from coordinator/app/src/test/resources
    • Create config files for the unit tests
  • Create a test that load the files inside config/coordoniator/**.toml to make sure thy are valid
@Pawar7349
Copy link

Hi @jpnovais,
I would like to work on issue #402.
Here’s my plan:
Adapt unit tests to use files from coordinator/app/src/test/resources.
Create configuration files for unit tests.
Add a test to ensure files in config/coordinator are valid.

@jpnovais
Copy link
Collaborator Author

jpnovais commented Dec 7, 2024

Hi @Pawar7349, yes that seems aligned with the tasks.
Please, fork the project and open a PR for review. Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants