Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): AttestV2 doesn't support customABI #857

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(sdk): AttestV2 doesn't support customABI #857

wants to merge 1 commit into from

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

Adds support for passing a custom ABI to the attestV2 function.
This lets anyone benefit from error decoding on their custom Portal.

Related ticket

Fixes #856

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls self-assigned this Dec 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.59%. Comparing base (6a6a9aa) to head (0b83207).

Files with missing lines Patch % Lines
sdk/src/dataMapper/PortalDataMapper.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #857   +/-   ##
=======================================
  Coverage   48.59%   48.59%           
=======================================
  Files          18       18           
  Lines         391      391           
  Branches       63       63           
=======================================
  Hits          190      190           
  Misses        198      198           
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls force-pushed the fix/attestv2-doesnt-support-customabi branch from 802b438 to 0b83207 Compare December 11, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyajeetkolhapure satyajeetkolhapure Awaiting requested review from satyajeetkolhapure satyajeetkolhapure is a code owner

@orbmis orbmis Awaiting requested review from orbmis orbmis is a code owner

@arthur-remy arthur-remy Awaiting requested review from arthur-remy arthur-remy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@alainncls alainncls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] AttestV2 doesn't support customABI
2 participants
@alainncls @codecov-commenter