Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a field for Phone Numbers (or use a library) #82

Open
giobber opened this issue Oct 8, 2023 · 5 comments
Open

Create a field for Phone Numbers (or use a library) #82

giobber opened this issue Oct 8, 2023 · 5 comments
Assignees

Comments

@giobber
Copy link
Member

giobber commented Oct 8, 2023

For reference:
https://django-phonenumber-field.readthedocs.io/en/latest/index.html

@VidyaYadavv1519
Copy link

Hii
Can you assign me this issue ??

@giobber giobber self-assigned this Oct 13, 2023
@giobber
Copy link
Member Author

giobber commented Oct 13, 2023

Yeah, thank you

@VidyaYadavv1519
Copy link

can you please elaborate more

@VidyaYadavv1519
Copy link

In this project you have different aaps in which app do you want phone number field ??

@giobber
Copy link
Member Author

giobber commented Oct 19, 2023

If I remember correctly (I'm a lot busy with other project in this weeks) at the moment Phone number is used only in member app in Member model (maybe I've added it in the PersonalData mixin)
In the future it will be added in academy app inside Enrollment model

The right place for a custom field is commons module (in a fields.py sub-module)
Instead the library https://django-phonenumber-field.readthedocs.io/en/latest/index.html I think declare itself a phone field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants