Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Test UBL-SR-43 / UBL-CR-665/666/673 for CreditNote #408

Open
AndreasPvd opened this issue Dec 5, 2024 · 10 comments
Open

Error in Test UBL-SR-43 / UBL-CR-665/666/673 for CreditNote #408

AndreasPvd opened this issue Dec 5, 2024 · 10 comments

Comments

@AndreasPvd
Copy link
Contributor

In case of a CreditNote it assumes the cbc:DocumentTypeCode="50" . According to CEN/TS 16931-3-2:2020 for a CreditNote the DocumentTypeCode for BT-18 in a CreditNote should be "ATS" and not "50".

@phax
Copy link
Collaborator

phax commented Dec 5, 2024

As the DocumentType code follows UNECE 1001, it cannot be ATS therefore I assume it is a bug in the specification:

https://service.unece.org/trade/untdid/d16b/tred/tred1001.htm

@phax phax added the Format UBL label Dec 5, 2024
@AndreasPvd
Copy link
Contributor Author

Thanks for clarification @phax.

  1. Could you please point out to the UBL 2.1 documentation where the use of that codelist is defined? I am currently unable to find any associated code list with that element from the documentation.
  2. If 1001 is the reason, why not use 130 for both? A price tender (code 50) seems not very useful to point to an invoiced object.

@MartinForsberg-Ecru
Copy link

@AndreasPvd I only have CEN/TS 16931-3-2:2021 (not 2020) at hand, and for BT-11, Project Reference, it doesn't say anything about ATS as qualifier. Actually, I can't see that it specifies any code (though 50 has been used since start in the schematrons). However, there seems the spec has an error in the example for BT-18 (Invoiced Object) where it says ATS in the cbc:DocumentType, it should have been 130 in cbc:DocumentTypeCode. To really confuse things, the examples are using the element cbc:DocumentType for textual description of document references, but there is no syntax binding to cbc:DocumentType, only cbc:DocumentDescription.

@MartinForsberg-Ecru
Copy link

130 is for Invoice Object (BT-18)
50 is for Project Reference (BT-11)

@AndreasPvd
Copy link
Contributor Author

@MartinForsberg-Ecru

  • is :2021 your national translation or the original English version? In German language I have a 2021 version as well, which is the translation of the English 2020 version.
  • 50 for Project Reference. Agreed. But BT-11 does not allow an additional scheme identifier. So UBL-SR-32 would be wrong in that case as well. Nevertheless, the text of SR-32 only talks about BT-18 and not BT-11.
  • You are right, the document is not consistent. The examples do not match the tables. Please have a look at Table 5 (normative!) in the row with BT-18. Here it clearly states to use ATS for BT-18

@MartinForsberg-Ecru
Copy link

I'm using the English version (there is not Swedish translation)

True, BT-11 (Project reference) should not have a schemeID. The rule is phrased incorrectly.

And for BT-11, you are correct, the syntax binding for CreditNote says ATS. What a mess.

@phax
Copy link
Collaborator

phax commented Dec 5, 2024

Ah BT-11 and not BT-18??
I saw it at BT-18:

grafik

@AndreasPvd
Copy link
Contributor Author

I was never talking about BT-11 ;)

@AndreasPvd AndreasPvd changed the title Error in Test UBL-SR-43 for CreditNote Error in Test UBL-SR-43 / UBL-CR-665 for CreditNote Dec 5, 2024
@AndreasPvd
Copy link
Contributor Author

AndreasPvd commented Dec 5, 2024

UBL-CR-665, UBL-CR-666, and UBL-CR-673 need to be addressed as well. UBL-CR-665, UBL-CR-666, UBL-CR-673, and UBL-SR-43 do not match because of the same reasons described above.

@AndreasPvd AndreasPvd changed the title Error in Test UBL-SR-43 / UBL-CR-665 for CreditNote Error in Test UBL-SR-43 / UBL-CR-665/666 for CreditNote Dec 5, 2024
@AndreasPvd AndreasPvd changed the title Error in Test UBL-SR-43 / UBL-CR-665/666 for CreditNote Error in Test UBL-SR-43 / UBL-CR-665/666/673 for CreditNote Dec 5, 2024
@phax
Copy link
Collaborator

phax commented Dec 6, 2024

Note: BT-11 is for CreditNotes and also maps to /CreditNote/cac:AdditionalDocumentReference/cbc:ID
So AdditionalDocumentReference/ID is relevant for BT-11, BT-18 and BT-122 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants