Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug romain #41

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Debug romain #41

wants to merge 7 commits into from

Conversation

morvanr
Copy link
Collaborator

@morvanr morvanr commented Jan 13, 2021

No description provided.

@ntraut
Copy link
Member

ntraut commented Jan 13, 2021

Hello, maybe it would be faster to merge if that PR were decomposed in several PRs for each issue it is addressing.

Looking process.browser may prevent from looking at localstorage when in ssr mode, but nothing seems to be done to replace this functionality. Is that supposed to work even without it?

What are supposed to do the last commits exactly? I tried to edit some tab parameters without saving manually but when i returned to the tab was back as before the edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants