-
|
I was having a look at https://github.com/conduitio-labs/conduit-connector-nats-pubsub/actions/runs/10891121733/job/30221354759 Seems to be the first cab off the rank for the new SDK update, and so I was wondering if the Markdown of the Test Results were updated but seems not, since this has not changed in ages: https://github.com/conduitio-labs/conduit-connector-nats-pubsub/tree/main/docs/qa Would like to know what the plan is with Integration tests with the new SDK ... |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
I'm not sure I understand what does the Markdown of the test results have to do with the SDK update and that run... I assume you are referring to the test results themselves and generally integration tests? We already have integration tests and also some acceptance tests. The test results in https://github.com/conduitio-labs/conduit-connector-nats-pubsub/tree/main/docs/qa are some additional manual tests. And yes, it's been a long time since we reviewed that. There's probably something that we can remove (because it was automated) and re-run the manual tests again. Thanks for calling this out, I'll bring it up on our daily sync! |
Beta Was this translation helpful? Give feedback.
-
|
Yep remove the technical debt |
Beta Was this translation helpful? Give feedback.
I'm not sure I understand what does the Markdown of the test results have to do with the SDK update and that run... I assume you are referring to the test results themselves and generally integration tests? We already have integration tests and also some acceptance tests. The test results in https://github.com/conduitio-labs/conduit-connector-nats-pubsub/tree/main/docs/qa are some additional manual tests. And yes, it's been a long time since we reviewed that. There's probably something that we can remove (because it was automated) and re-run the manual tests again.
Thanks for calling this out, I'll bring it up on our daily sync!