Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ChannelId and PortId structs from ibc rs in memo instead of string #376

Open
RustNinja opened this issue Jul 21, 2023 · 1 comment
Open

Use ChannelId and PortId structs from ibc rs in memo instead of string #376

RustNinja opened this issue Jul 21, 2023 · 1 comment
Assignees
@RustNinja
Labels
Low Low priority, should be done, if no Normal or High are present, or during enhancement sprint

Comments

@RustNinja
Copy link
Contributor 

pub struct Forward {
	....
	pub port: Option<PortId>,
	#[serde(skip_serializing_if = "Option::is_none")]
	pub channel: Option<ChannelId>,
	#[serde(skip_serializing_if = "Option::is_none")]
}

need replace String to PortId and ChannelId to prevent a bug with the channel format
{text}-{text}-{number}
@RustNinja RustNinja added the Low Low priority, should be done, if no Normal or High are present, or during enhancement sprint label Jul 21, 2023
@RustNinja RustNinja self-assigned this Jul 21, 2023
@josietyleung
Copy link

hi @RustNinja is this done already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RustNinja RustNinja

Labels
Low Low priority, should be done, if no Normal or High are present, or during enhancement sprint
Projects
Bridging team board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josietyleung @RustNinja