Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unit test coverage #34

Open
alfinkel opened this issue Aug 26, 2020 · 0 comments
Open

More unit test coverage #34

alfinkel opened this issue Aug 26, 2020 · 0 comments
Labels
enhancement New feature or request test Test related issue

Comments

@alfinkel
Copy link
Contributor

Overview

We should look to ensure that we have unit tests for all of the framework components.

Requirements

compliance/__init__.py                       2      0   100%
compliance/check.py                        135     48    64%
compliance/config.py                        72     26    64%
compliance/controls.py                      38     25    34%
compliance/evidence.py                     291    162    44%
compliance/fetch.py                         45     26    42%
compliance/fix.py                           30      0   100%
compliance/locker.py                       360     86    76%
compliance/notify.py                       538     84    84%
compliance/report.py                       102     32    69%
compliance/runners.py                      215    164    24%
compliance/scripts/__init__.py               1      1     0%
compliance/scripts/compliance_cli.py        66     66     0%
compliance/utils/__init__.py                 1      0   100%
compliance/utils/credentials.py             42     31    26%
compliance/utils/data_parse.py              31     12    61%
compliance/utils/exceptions.py              11      0   100%
compliance/utils/http.py                    10      3    70%
compliance/utils/path.py                    26     15    42%
compliance/utils/services/__init__.py        1      0   100%
compliance/utils/services/github.py        265    203    23%
compliance/utils/services/pagerduty.py      45     31    31%
compliance/utils/test.py                     5      0   100%
------------------------------------------------------------
TOTAL                                     2332   1015    56%

we should be looking to get that to the 90%+ coverage range.

Approach

  • add more unit tests

Security and Privacy

N/A

Test Plan

TBD

@alfinkel alfinkel added enhancement New feature or request test Test related issue labels Aug 26, 2020
This was referenced Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Test related issue
Projects
None yet
Development

No branches or pull requests

1 participant