Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency validation support #4430

Closed
wants to merge 2 commits into from
Closed

Currency validation support #4430

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa1878b
currency validation support
olegL1337 Dec 16, 2021
392b783
regex fix :)
olegL1337 Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Microsoft.Toolkit.Uwp.UI/Extensions/TextBox/TextBoxExtensions.Regex.Data.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ public enum ValidationType
/// </summary>
Decimal,

/// <summary>
/// Currency validation
/// </summary>
Currency,

Comment on lines +56 to +60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be added at the end so not a breaking change.

/// <summary>
/// Text only validation
/// </summary>
Expand Down
6 changes: 6 additions & 0 deletions Microsoft.Toolkit.Uwp.UI/Extensions/TextBox/TextBoxExtensions.Regex.Internals.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,12 @@ private static void ValidateTextBox(TextBox textBox, bool force = true)
case ValidationType.Decimal:
regexMatch = textBox.Text.IsDecimal();
break;
case ValidationType.Currency:
// @"(^\d*\.\d{2}$)" regex pattern to detect currency sign with currency value
// Mathes: $100.00, $100, $10.25
// Non-Matches: 100., $10.233, $10.
regexMatch = Regex.IsMatch(textBox.Text, @"(^\d*\.\d{2}$)");
Copy link
Member

@Arlodotexe Arlodotexe Dec 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should handle currency symbols and decimal separators other than USD. Luckily, dotnet has this functionality built in and we don't need to fiddle with Regex.

System.Globalization.NumberFormatInfo should have everything we need for this.

Firing up an empty console app, here's what we have to work with.

string FormatCurrency(string value)
{
    // Parse the entered data into a decimal, allowing existing currency symbols.
    decimal.TryParse(value, NumberStyles.Currency, out var amount);

    // Format the decimal into a human readable string for the current culture.
    return amount.ToString("C2", CultureInfo.CurrentCulture);
}

// Stress testing USD
FormatCurrency("500"); // $500.00
FormatCurrency("5"); // $5.00
FormatCurrency("5.00"); // $5.00
FormatCurrency(".05"); // $0.05
FormatCurrency(".5"); // $0.50
FormatCurrency("$.5"); // $0.50

// With other cultures
FormatCurrency("5"); // nl-NL, € 5,00
FormatCurrency("5"); // fr-FR, 5,00 €
FormatCurrency("5"); // ja-JP, ¥5.00
FormatCurrency("5"); // en-GB, £5.00

break;
case ValidationType.Email:
regexMatch = textBox.Text.IsEmail();
break;
Expand Down