Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WrapLayout gallery sample never loads, is unusably slow under Windows App SDK #515

Open
1 of 24 tasks
Arlodotexe opened this issue Sep 18, 2024 · 3 comments
Open
1 of 24 tasks
Assignees
Labels
bug Something isn't working regression What was working is now broke sample app 🖼️

Comments

@Arlodotexe
Copy link
Member

Describe the bug

The WrapLayout sample in the gallery never fully loads when running under Windows App SDK but is fine when running UWP.

Recording.2024-09-18.141302.mp4

Steps to reproduce

1. Clone the repo
2. Generate the gallery solution, include the Primitives component and the wasdk multitarget/head.
3. Build and deploy the wasdk gallery.
4. Navigate to the 'WrapLayout' sample page and observe laggy behavior.

Expected behavior

Control should load and be reasonably responsive.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

@Arlodotexe Arlodotexe added bug Something isn't working sample app 🖼️ regression What was working is now broke labels Sep 18, 2024
@Arlodotexe Arlodotexe moved this to 🆕 New in Toolkit 8.x Sep 18, 2024
@Arlodotexe Arlodotexe moved this from 🆕 New to 🏗 In progress in Toolkit 8.x Oct 10, 2024
@Arlodotexe Arlodotexe self-assigned this Oct 10, 2024
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Oct 10, 2024

Looks like there's no slowdowns or unexpected bugs when AoT is disabled. Might be a binding issue or an indication of a deeper layout problem when AoT is on.

We'll need to run a profiler to see what the hot paths are during the slowdown.

@Arlodotexe
Copy link
Member Author

Looks like the hot paths are found on both the MeasureOverride and ArrangeOverride calls in WrapLayout, with the majority of time spent on ABI.Microsoft.UI.Xaml.Controls.IVirtualizingLayoutContextMethods.GetOrCreateElementAt(WinRT.IObjectReference, int) in both methods:

MeasureOverride:
Image

ArrangeOverride:
Image

This seems abnormal, possibly due to a change in CsWinRT?

@Arlodotexe
Copy link
Member Author

Updating to the latest CsWinRT 2.1.5 has no effect, issue is still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression What was working is now broke sample app 🖼️
Projects
Status: 🏗 In progress
Development

No branches or pull requests

1 participant