Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Console Do Not Track #131

Open
allo- opened this issue Jul 18, 2024 · 0 comments
Open

Implement Console Do Not Track #131

allo- opened this issue Jul 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@allo-
Copy link

allo- commented Jul 18, 2024

comfy-cli implements tracking via Mixpanel, that seems to be enabled and disabled only by a config value of comfy-cli itself:

enable_tracking = config_manager.get(constants.CONFIG_KEY_ENABLE_TRACKING)

It would be good, if it could also respect the Console Do Not Track standard described here: https://consoledonottrack.com

Describe the solution you'd like
comfy-cli should read the DO_NOT_TRACK environment variable and disable tracking if it has a truthy value.

Here is an example implementation:
https://github.com/huggingface/huggingface_hub/blob/f77c1c9f90b462727c581fec349e6c781c886265/src/huggingface_hub/constants.py#L121

Describe alternatives you've considered
Tracking could be opt-in.

Additional context
A lot of other console tools already use the unified DO_NOT_TRACK environment variable, helping users to make sure not to forget an opt-out if they dislike telemetry.

@allo- allo- added the enhancement New feature or request label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant