Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip uploading new but discarded attachments #2251

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: skip uploading new but discarded attachments #2251

merged 1 commit into from
Dec 4, 2024

Conversation

headri
Copy link
Contributor

@headri headri commented Dec 3, 2024

When deleting attachments after adding them in a dataset and before saving, they are no longer uploaded and deleted afterwards.

@headri headri requested a review from PiTrem December 3, 2024 14:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

LCOV of commit c07363e during Continuous Integration #4192

Summary coverage rate:
  lines......: 65.6% (14054 of 21437 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@PiTrem PiTrem merged commit 5238ff4 into main Dec 4, 2024
3 checks passed
@PiTrem PiTrem changed the title fix: no more uploading of deleted attachments fix: skip uploading new but discarded attachments Dec 4, 2024
PiTrem pushed a commit that referenced this pull request Dec 4, 2024
@headri @PiTrem
fix: skip uploading new but discarded attachments (#2251)
fa9f9d1 
Co-authored-by: Adrian Herrmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiTrem PiTrem PiTrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@headri @PiTrem