feat: Incorporate "Gas Scheme" feature in reaction variations table #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example of the reaction variations data structure is unnecessarily verbose and prone to be outdated.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| expose :volume, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :yield, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
|
|
||
| expose :duration, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' |
There was a problem hiding this comment.
Style/Lambda: Use the -> { ... } lambda literal syntax for single line lambdas.
| expose :volume, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :yield, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
|
|
||
| expose :duration, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [137/120]
| expose :yield, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
|
|
||
| expose :duration, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :temperature, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' |
There was a problem hiding this comment.
Style/Lambda: Use the -> { ... } lambda literal syntax for single line lambdas.
| expose :yield, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
|
|
||
| expose :duration, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :temperature, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [140/120]
|
|
||
| expose :duration, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :temperature, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :concentration, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' |
There was a problem hiding this comment.
Style/Lambda: Use the -> { ... } lambda literal syntax for single line lambdas.
| expose :temperature, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :concentration, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :turnoverNumber, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :turnoverFrequency, if: lambda { |object, _| object[:aux][:gasType] == 'gas' }, using: 'Entities::ReactionVariationMaterialEntryEntity' |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [146/120]
| expose :amount, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :equivalent, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
|
|
||
| expose :volume, if: lambda { |object, _| (object[:aux][:gasType] == 'feedstock') }, using: 'Entities::ReactionVariationMaterialEntryEntity' |
There was a problem hiding this comment.
Style/Lambda: Use the -> { ... } lambda literal syntax for single line lambdas.
| expose :amount, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
| expose :equivalent, using: 'Entities::ReactionVariationMaterialEntryEntity' | ||
|
|
||
| expose :volume, if: lambda { |object, _| (object[:aux][:gasType] == 'feedstock') }, using: 'Entities::ReactionVariationMaterialEntryEntity' |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [143/120]
| @@ -60,23 +60,25 @@ def variations | |||
| 'startingMaterials' => variation_materials(var, :startingMaterials), | |||
| 'reactants' => variation_materials(var, :reactants), | |||
| 'solvents' => variation_materials(var, :solvents), | |||
| 'products' => variation_products(var), | |||
| 'products' => variation_materials(var, :products), | |||
There was a problem hiding this comment.
Metrics/ClassLength: Class has too many lines. [626/200]
| (v[:aux][:isReference] ? '; Ref' : '') | ||
| end | ||
| end | ||
| variation[type].map do |_, vi| |
There was a problem hiding this comment.
Metrics/CyclomaticComplexity: Cyclomatic complexity for variation_materials is too high. [8/7]
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2213.
See also https://docs.google.com/document/d/1Jd6V5zqRv0cfw_xAJE-oHDYzSuBMQyBBz3wQQBxRGJo/edit and https://www.chemotion.net/docs/eln/ui/elements/reactions?_highlight=gas#gas-phase-reaction-scheme.