Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bootstrap styles #2225

Merged
merged 8 commits into from
Dec 3, 2024
Merged

fix: bootstrap styles #2225

merged 8 commits into from
Dec 3, 2024

Conversation

ashwiniHerle
Copy link
Contributor

@ashwiniHerle ashwiniHerle commented Oct 23, 2024 •
edited
Loading

This PR fixes minor bugs/ issues based on the feedback received after bootstrap upgrade.

Bootstrap related issues are documented here:
https://docs.google.com/document/d/1BuMr3nycc0ZAvia8rT6QVnQ-YS14hivRazIlzBxceCw/edit?tab=t.0#heading=h.12fbp2kablsg

@github-actions GitHub Actions
Copy link

LCOV of commit ae7bf14 during Continuous Integration #4050

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@adambasha0
Copy link
Contributor

adambasha0 commented Oct 24, 2024 •
edited
Loading

STAGE.unstrapped.webm

@PiTrem PiTrem changed the title Fix bootstrap feedback fixes fix: bootstrap styles Nov 7, 2024
@ashwiniHerle ashwiniHerle linked an issue Nov 19, 2024 that may be closed by this pull request
Bootstrap bugfixes after feedback #2244
Closed
@ashwiniHerle ashwiniHerle force-pushed the fix-bootstrap-feedback-fixes branch from ed94b76 to 0c15eb9 Compare December 3, 2024 09:20
@ashwiniHerle ashwiniHerle marked this pull request as ready for review December 3, 2024 09:20
@ashwiniHerle ashwiniHerle requested a review from PiTrem December 3, 2024 09:21
@ashwiniHerle ashwiniHerle self-assigned this Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

LCOV of commit 0c15eb9 during Continuous Integration #4187

Summary coverage rate:
  lines......: 65.5% (14036 of 21437 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@PiTrem PiTrem merged commit 2e043bf into main Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiTrem PiTrem PiTrem approved these changes

Assignees

@ashwiniHerle ashwiniHerle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap bugfixes after feedback
3 participants
@ashwiniHerle @adambasha0 @PiTrem