User login test case #3384
Open
User login test case #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #7849 ↗︎
Details:
Review all test suite changes for PR #3384 ↗︎ |
|||||||||||||||
|
Coverage report for commit: ff24d03 Summary - Lines: 3.35% | Methods: 5.49%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
AbhishekNegi25
added
the
status : ready for review
pankaj-ag
requested changes
Oct 18, 2023
tests/Feature/UserLogInTest.php
Outdated
Comment on lines
14
to
17
| public function test_example() | ||
| { | ||
| $this->userLogInFailedWithWrongPassword(); | ||
| $this->userLogIn(); |
There was a problem hiding this comment.
Move the test function in this file
tests/TestCase.php
Outdated
Comment on lines
28
to
45
| protected function userLogIn() | ||
| { | ||
| $password = 'admin'; | ||
| $user = User::factory()->create([ | ||
| 'name' => 'User', | ||
| 'email' => '[email protected]', | ||
| 'password' => bcrypt($password), | ||
| ]); | ||
|
|
||
| $response = $this->post('/login', [ | ||
| 'email' => $user->email, | ||
| 'password' => $password, | ||
| ]); | ||
|
|
||
| $response->assertRedirect('/home'); | ||
| $this->assertAuthenticatedAs($user); | ||
| } | ||
|
|
tests/Feature/UserLogInTest.php
Outdated
| $user = User::factory()->create([ | ||
| 'name' => 'User', | ||
| 'email' => '[email protected]', | ||
| 'password' => bcrypt($password), |
There was a problem hiding this comment.
Suggested change
| 'password' => bcrypt($password), | |
| 'password' => Hash::make($password), |
tests/Feature/UserLogInTest.php
Outdated
| $user = User::factory()->create([ | ||
| 'name' => 'admin', | ||
| 'email' => '[email protected]', | ||
| 'password' => bcrypt('Admin'), |
There was a problem hiding this comment.
Suggested change
| 'password' => bcrypt('Admin'), | |
| 'password' => Hash::make('Admin'), |
pankaj-ag
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are now implementing the Test cases for User login.